📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/LAuMXw

There seem to be some diffs in the screenshots, should we generate new ones?

It seems like this version broke all the dialog previews in screens using Scaffold 🫤 .

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

I opened an issue in Paparazzi's repo: cashapp/paparazzi#2071, maybe it's Compose, maybe it's a combination of that and the alpha version.

It also seems to affect the preview in Android Studio, see for instance this hack, where the dialog is rendered only on the first preview:

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.01%. Comparing base (81739d2) to head (c45b511).
⚠️ Report is 16 commits behind head on develop.

@@             Coverage Diff             @@
##           develop    #5179      +/-   ##
===========================================
- Coverage    81.02%   81.01%   -0.01%     
===========================================
  Files         2312     2312              
  Lines        63448    63450       +2     
  Branches      8010     8010              
===========================================
- Hits         51407    51403       -4     
- Misses        9103     9106       +3     
- Partials      2938     2941       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

It also seems to affect the preview in Android Studio, see for instance this hack, where the dialog is rendered only on the first preview:

I can reproduce it.

Maybe it's because of this commit? It's the latest one added to AndroidDialog.android.kt, and it affects the measured size of the dialog.

It started happening on 1.9.0-alpha01, so any of the changes added in that version could have caused it.

Just FYI, the Compose BOM 2025.08.01 still has this issue. I created an issue in the Google Issue tracker, but they moved it to a different category and is no longer visible for public users (not even for me!).

I was hoping this commit in the latest alpha version would fix it, assuming it restored the previous behaviour, but it doesn't.

Oh, maybe it's this one instead, in which case there's not much we can do 🫤 .

Oh, maybe it's this one instead, in which case there's not much we can do 🫤 .

I can confirm that's it, sadly. I created a copy of Dialog with the previous DisposableEffect(dialog) { dialog.show() } instead of LaunchedEffect(dialog) { dialog.show() } and the previews in the IDE are working again.

So there's not much we can do about it, that's how the Compose component will behave from now on. They could probably fix it on their end by changing which effect to use based on LocalInspectionMode.current, but if they don't we're stuck with the new behaviour.

Regression tracked by https://issuetracker.google.com/issues/442273708

Generated by 🚫 dangerJS against c45b511

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

The dialog issues seem to be fixed on the AS Narwhal RC versions and the current Paparazzi 2.0.0-SNAPSHOT. I guess we'll need to wait until the Paparazzi releases a new RC, by that time we should also have an stable AS version with the fix for previews.